Skip to content

feat: warn when main cpp skips ino preprocessing#659

Merged
zackees merged 1 commit into
mainfrom
feat/650-warn-main-cpp-skips-ino
Jun 19, 2026
Merged

feat: warn when main cpp skips ino preprocessing#659
zackees merged 1 commit into
mainfrom
feat/650-warn-main-cpp-skips-ino

Conversation

@zackees

@zackees zackees commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

  • print a yellow warning when main.cpp and .ino files coexist and automatic .ino preprocessing is skipped
  • keep compiling through main.cpp in that case
  • cover warning text, silence for main.cpp-only, and scanner skip behavior in tests
  • document main.cpp precedence in the PlatformIO compatibility notes

Closes #650

Tests

  • soldr cargo fmt
  • soldr cargo test -p fbuild-build source_scanner
  • soldr cargo clippy -p fbuild-build --all-targets -- -D warnings
  • soldr zccache stop; soldr cargo test -p fbuild-build

Note: the first full soldr cargo test -p fbuild-build attempt failed before compilation while starting the private zccache session (0xffffffff). Retried after soldr zccache stop, and the full package test passed.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 50 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5af4b32b-cb5b-488d-9469-a6bac59f0f4b

📥 Commits

Reviewing files that changed from the base of the PR and between b90f0e9 and 9807e9e.

📒 Files selected for processing (2)
  • crates/fbuild-build/src/source_scanner.rs
  • docs/reference/platformio-compatibility.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/650-warn-main-cpp-skips-ino

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 8da6457 into main Jun 19, 2026
85 of 91 checks passed
@zackees zackees deleted the feat/650-warn-main-cpp-skips-ino branch June 19, 2026 20:36
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

feat: warn when main.cpp causes ino preprocessing to be skipped

1 participant